Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corebird: move deprecation warning to aliases and release notes #70293

Merged
merged 1 commit into from Oct 2, 2019
Merged

corebird: move deprecation warning to aliases and release notes #70293

merged 1 commit into from Oct 2, 2019

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Oct 2, 2019 •
edited

Follow-up to #70168: The deprecation warnings needed to be moved to the appropriate places as discussed in #70287

/cc @worldofpeace

@schmittlauch
Copy link
Member Author

@GrahamcOfBorg eval

1 similar comment
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg eval

@worldofpeace
Copy link
Contributor

Hmm, I think something's up with ofborg.

@schmittlauch
Copy link
Member Author

@worldofpeace Isn't a nix-review on your machine enough?

worldofpeace
worldofpeace approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@worldofpeace worldofpeace merged commit 355425b into NixOS:master Oct 2, 2019
@schmittlauch
Copy link
Member Author

@worldofpeace So you'll do the backport to 19.09 then? Thanks.

@worldofpeace
Copy link
Contributor

Yep, checking that now @schmittlauch.

@worldofpeace
Copy link
Contributor

worldofpeace commented Oct 2, 2019 •
edited

backported in 8349643 b919677 5e0b687

@schmittlauch schmittlauch deleted the cawbird2 branch October 2, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schmittlauch @worldofpeace