Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.2.22 -> 7.2.23, 7.3.9 -> 7.3.10 #70370

Merged
merged 2 commits into from Oct 5, 2019
Merged

php: 7.2.22 -> 7.2.23, 7.3.9 -> 7.3.10 #70370

merged 2 commits into from Oct 5, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 4, 2019 •
edited

Motivation for this change

Changelog: https://www.php.net/ChangeLog-7.php#7.3.10
Changelog: https://www.php.net/ChangeLog-7.php#7.2.23

So far I've only made sure the hashes works, but I will build all the things on a more powerful system and check boxes below accordingly.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from globin October 4, 2019 07:16
@etu etu added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 4, 2019
@etu etu requested a review from Izorkin October 4, 2019 08:08
@Ma27
Copy link
Member

Ma27 commented Oct 4, 2019

Diff seems fine, currently running nix-review locally.

@Ma27
Copy link
Member

Ma27 commented Oct 4, 2019

Btw nix-review runs into a timeout due to libcouchbase. This appears to be an issue with openssl 1.1.1, I'll check if upstream has some patches for this :)

@Izorkin
Copy link
Contributor

Izorkin commented Oct 4, 2019

On my home server php 7.2.23 (with libressl) is working fine.

@Ma27
Copy link
Member

Ma27 commented Oct 4, 2019

Yeah, the problem isn't related to php, but to libcouchbase (which is used by phpPackages.couchbase). I'd try to fix the libcouchbase issue tomorrow, but it's perfectly fine if someone merges this before :)

@Ma27
Copy link
Member

Ma27 commented Oct 5, 2019

Libcouchbase is fixed in #70455. I'll rerun nix-review with my patch, but I don't expect any further issues :)

@Ma27 Ma27 merged commit e7caa11 into NixOS:master Oct 5, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 5, 2019

Thanks! Backported as 63b18e7, 6ae771e.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 5, 2019
@etu etu deleted the php-upgrades branch October 7, 2019 05:39
@etu
Copy link
Contributor Author

etu commented Oct 7, 2019

@Ma27 Thanks yourself for looking into libcouchbase :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@globin globin Awaiting requested review from globin globin is a code owner

@Izorkin Izorkin Awaiting requested review from Izorkin

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @Ma27 @Izorkin