Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch kdelibs for CVE-2019-14744 #70264

Merged
merged 5 commits into from Oct 3, 2019
Merged

Patch kdelibs for CVE-2019-14744 #70264

merged 5 commits into from Oct 3, 2019

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Oct 2, 2019

Motivation for this change

See also: #70102

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ttuegel ttuegel requested a review from FRidh as a code owner October 2, 2019 18:39
@FRidh FRidh requested a review from a user October 2, 2019 20:26
ghost
ghost suggested changes Oct 2, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't. I still use and maintain it. You may mark it as broken instead.

@FRidh
Copy link
Member

FRidh commented Oct 2, 2019

maintained yet broken? We can mark it as insecure, but really, it's a very old package. I think at this point you better use it from an older Nixpkgs version.

@ghost
Copy link

ghost commented Oct 2, 2019

@FRidh Since there are no other known users of it... Actually @ttuegel made a patch for that CVE in #70102 that went into 19.03, why not merge it to master too? I would prefer to keep it since pykde5 is an old wip.

@ttuegel
Revert "Remove pykde4"
e98b64c 
This reverts commit a3ad16b.
@ttuegel
kdelibs: gnidorah is maintainer
ee36267
@ttuegel
pykde4: Do not build on Hydra
260ef79 
pykde4 is not used in Nixpkgs, so it is not appropriate to build on Hydra.
@ttuegel
Copy link
Member Author

ttuegel commented Oct 2, 2019

Actually @ttuegel made a patch for that CVE in #70102 that went into 19.03, why not merge it to master too?

@gnidorah I didn't make the patch, it comes from upstream. I cherry-picked the changes from release-19.03, marked you as maintainer of both packages, and disabled the Hydra build.

delroth
delroth reviewed Oct 2, 2019
View reviewed changes
pkgs/development/python-modules/pykde4/kdelibs.nix Outdated
(fetchpatch {
url = "https://cgit.kde.org/kdelibs.git/patch/?id=2c3762feddf7e66cf6b64d9058f625a715694a00";
sha256 = "1wbzywh8lcc66n6y3pxs18h7cwkq6g216faz27san33jpl8ra1i9";
name = "kdelibs-D22989.patch";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CVE-2019-14744.patch (see #70102 (comment))

@ttuegel ttuegel changed the title Remove pykde4 Patch kdelibs for CVE-2019-14744 Oct 2, 2019
ghost
ghost approved these changes Oct 3, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ttuegel ttuegel merged commit 629f713 into NixOS:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @FRidh @delroth