Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nettle: 3.4.1 -> 3.5.1 #68593

Merged
merged 2 commits into from Oct 2, 2019
Merged

nettle: 3.4.1 -> 3.5.1 #68593

merged 2 commits into from Oct 2, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Sep 12, 2019 •
edited

Motivation for this change

#68361 🤔

So I got confused while fixing viking and somehow ended up thinking nettle was broken too (hint: it is not). See #68595) for actual ZHF PR 🤷‍♂️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@globin
Copy link
Member

globin commented Sep 24, 2019

Please switch this to staging

@aanderse aanderse changed the base branch from master to staging September 24, 2019 15:09
@aanderse
Copy link
Member Author

Thanks @globin!

@ttuegel ttuegel removed their request for review September 24, 2019 15:51
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

... why does this cause so many rebuilds...

@vcunat
Copy link
Member

vcunat commented Oct 2, 2019

I think most will be through gnutls, as that's one of the more popular crypto-libraries.

vcunat
vcunat requested changes Oct 2, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unbound build is broken by this, which results into a mass breakage (through a DANE library in gnutls). We'll need to resolve that before merging.

@vcunat vcunat self-assigned this Oct 2, 2019
vcunat
vcunat approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS seems nice (speedups!), and I don't expect any other significant breakages.

@vcunat
Copy link
Member

vcunat commented Oct 2, 2019

Lemme cross-link the tickets: NLnetLabs/unbound#90.

vcunat added a commit that referenced this pull request Oct 2, 2019
@vcunat
Merge #68593: nettle: 3.4.1 -> 3.5.1 into staging
a215655
@vcunat vcunat merged commit 96d6587 into NixOS:staging Oct 2, 2019
@aanderse aanderse deleted the zhf/nettle branch October 2, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@peti peti Awaiting requested review from peti

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees

@vcunat vcunat

Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @globin @jonringer @vcunat