Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spaCy and spaCy models to 2.2.0 #70262

Merged
merged 4 commits into from Oct 3, 2019
Merged

Update spaCy and spaCy models to 2.2.0 #70262

merged 4 commits into from Oct 3, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Oct 2, 2019

Motivation for this change

Changelog:

https://github.com/explosion/spaCy/releases/tag/v2.2.0

This PR couples a few changes:

  • Update spaCy dependencies where necessary.
  • Update spaCy to version 2.2.0.
  • Update existing model derivations to models compatible with version 2.2.0.

I will do a separate PR after this one, adding new models. Note that the en_vectors_web_lg models still has version 2.1.0, this version is compatible with spaCy 2.2.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk danieldk requested a review from FRidh as a code owner October 2, 2019 18:15
@danieldk
Copy link
Contributor Author

danieldk commented Oct 2, 2019

@GrahamcOfBorg build python3Packages.spacy_models.de_core_news_md python3Packages.spacy_models.de_core_news_sm python3Packages.spacy_models.el_core_news_md python3Packages.spacy_models.el_core_news_sm python3Packages.spacy_models.en_core_web_lg python3Packages.spacy_models.en_core_web_md python3Packages.spacy_models.en_core_web_sm python3Packages.spacy_models.en_vectors_web_lg python3Packages.spacy_models.es_core_news_md python3Packages.spacy_models.es_core_news_sm python3Packages.spacy_models.fr_core_news_md python3Packages.spacy_models.fr_core_news_sm python3Packages.spacy_models.it_core_news_sm python3Packages.spacy_models.nl_core_news_sm python3Packages.spacy_models.pt_core_news_sm python3Packages.spacy_models.xx_ent_wiki_sm

@ofborg ofborg bot requested a review from aborsu October 2, 2019 18:33
@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.preshed python27Packages.thinc python37Packages.preshed python37Packages.spacy python37Packages.textacy python37Packages.thinc

jonringer
jonringer approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
spacy executable seems to work

[10 built, 61 copied (141.2 MiB), 29.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70262
6 package were build:
python27Packages.preshed python27Packages.thinc python37Packages.preshed python37Packages.spacy python37Packages.textacy python37Packages.thinc

@jonringer jonringer merged commit c4fdb91 into NixOS:master Oct 3, 2019
@danieldk danieldk deleted the spacy-2.2.0 branch October 3, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@aborsu aborsu Awaiting requested review from aborsu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @jonringer