Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs_latest: 12.5.0 -> 12.11.1 #70253

Closed
wants to merge 1 commit into from
Closed

nodejs_latest: 12.5.0 -> 12.11.1 #70253

wants to merge 1 commit into from

Conversation

johannesloetzsch
Copy link
Contributor

libuv: 1.30.1 -> 1.32.0

Motivation for this change

nodejs_latest was really out of date

Things done

Upgraded nodejs-12_x and libuv.
Since nodejs-12.9.0 at least libuv-1.31.0 is required.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cillianderoiste @gilligan @cko @cstrahan

@johannesloetzsch
nodejs_latest: 12.5.0 -> 12.11.1
1cf5ef9 
libuv: 1.30.1 -> 1.32.0
@ofborg ofborg bot requested a review from cstrahan October 2, 2019 14:09
@marsam
Copy link
Contributor

marsam commented Oct 2, 2019

staging already has 12.10.0, which contains a patch for Darwin 7db9c4c. I'd wait until it lands into master to bump it to 12.11.1

@marsam marsam mentioned this pull request Oct 15, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johannesloetzsch @marsam