Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.19.0 -> 0.20.1 #70385

Merged
merged 1 commit into from Oct 4, 2019
Merged

starship: 0.19.0 -> 0.20.1 #70385

merged 1 commit into from Oct 4, 2019

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Oct 4, 2019 •
edited

Motivation for this change

v0.20.0 (and then v0.20.1) of Starship was released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bbigras

@ofborg ofborg bot requested a review from bbigras October 4, 2019 11:18
@davidtwco davidtwco changed the title starship: 0.19.0 -> 0.20.0 starship: 0.19.0 -> 0.20.1 Oct 4, 2019
Lassulus
Lassulus approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, ran some commands, everything seems to work

@Lassulus
Copy link
Member

Lassulus commented Oct 4, 2019

ah maybe you could sqaush the commits into one?

@davidtwco
Copy link
Member Author

ah maybe you could sqaush the commits into one?

Squashed, thanks!

@Lassulus Lassulus merged commit 1442f70 into NixOS:master Oct 4, 2019
@davidtwco davidtwco mentioned this pull request Oct 5, 2019
Merged
10 tasks
@davidtwco davidtwco deleted the starship-0.20.0 branch October 5, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@bbigras bbigras Awaiting requested review from bbigras

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @Lassulus