Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CSSMinifierXS: rename from perlPackages.CSSMinifierXP #70387

Merged
merged 1 commit into from Oct 20, 2019
Merged

perlPackages.CSSMinifierXS: rename from perlPackages.CSSMinifierXP #70387

merged 1 commit into from Oct 20, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 4, 2019 •
edited

The attribute for the CSS::Minifier::XS module was likely misnamed, this commit changes
the attribute name from CSSMinifierXP to CSSMinifierXS.

One dependency was affected by this change, it has been updated.

Affected dependencies:

  • servers/rt
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @volth

@stigtsp stigtsp changed the title perlPackages.CSSMinifierXP: rename attribute to CSSMinifierXS perlPackages.CSSMinifierXS: rename attribute from CSSMinifierXP Oct 4, 2019
@stigtsp
Copy link
Member Author

stigtsp commented Oct 4, 2019

@GrahamcOfBorg eval

@stigtsp stigtsp force-pushed the package/perl-css-minifier-xs-rename branch 2 times, most recently from c33c25f to 9990376 Compare October 4, 2019 12:43
@stigtsp stigtsp changed the title perlPackages.CSSMinifierXS: rename attribute from CSSMinifierXP perlPackages.CSSMinifierXS: rename from perlPackages.CSSMinifierXP Oct 4, 2019
@stigtsp
perlPackages.CSSMinifierXS: rename from perlPackages.CSSMinifierXP
68bae31 
The attribute CSS::Minifier::XS module was likely misnamed, this commit changes
the attribute name from CSSMinifierXP to CSSMinifierXS.

Affected dependency: servers/rt
@stigtsp stigtsp force-pushed the package/perl-css-minifier-xs-rename branch from 9990376 to 68bae31 Compare October 4, 2019 12:48
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2019

@GrahamcOfBorg build perl528Packages.CSSMinifierXP perl530Packages.CSSMinifierXP rt

1 similar comment
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 20, 2019

@GrahamcOfBorg build perl528Packages.CSSMinifierXP perl530Packages.CSSMinifierXP rt

@c0bw3b c0bw3b merged commit a8cbf23 into NixOS:master Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @c0bw3b