Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdcat: init at 0.13.0 #70388

Merged
merged 2 commits into from Oct 5, 2019
Merged

mdcat: init at 0.13.0 #70388

merged 2 commits into from Oct 5, 2019

Conversation

davidtwco
Copy link
Member

Motivation for this change

Adds a package for mdcat (and ansi2html for mdcat's testing).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

me!

@davidtwco davidtwco requested a review from FRidh as a code owner October 4, 2019 11:36
@teto
Copy link
Member

teto commented Oct 4, 2019

@GrahamcOfBorg build mdcat

@teto
Copy link
Member

teto commented Oct 5, 2019

tested and working. Before merging, could you split the python package in a separate commit please ?

@davidtwco
Copy link
Member Author

tested and working. Before merging, could you split the python package in a separate commit please ?

Done, thanks!

@teto
Copy link
Member

teto commented Oct 5, 2019

@GrahamcOfBorg build mdcat

@teto teto merged commit e3c3b5f into NixOS:master Oct 5, 2019
@teto
Copy link
Member

teto commented Oct 5, 2019

thanks

@davidtwco davidtwco deleted the mdcat-init branch October 5, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidtwco @teto