Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

essentia: init at 2.1_beta5 #70389

Closed
wants to merge 2 commits into from
Closed

essentia: init at 2.1_beta5 #70389

wants to merge 2 commits into from

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Can help bring support for the beets plugin AcousticBrainz Submit Plugin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@doronbehar doronbehar requested a review from FRidh as a code owner October 4, 2019 11:39
@doronbehar
Copy link
Contributor Author

Depends upon #70372

doronbehar added a commit to doronbehar/nixpkgs that referenced this pull request Oct 4, 2019
@doronbehar
Add support for absubmit plugin using essentia
5ec290f 
Using essentia (NixOS#70389), it's possible to enable the absubmit plugin.
@doronbehar doronbehar mentioned this pull request Oct 4, 2019
Closed
10 tasks
doronbehar
doronbehar commented Oct 5, 2019
View reviewed changes
Copy link
Contributor Author

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented and pushed changes.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/71

@doronbehar doronbehar changed the title essentia: init at: 2.1_beta5 essentia: init at 2.1_beta5 Nov 8, 2019
@doronbehar doronbehar mentioned this pull request Nov 8, 2019
Merged
10 tasks
@matthewbauer
Copy link
Member

@GrahamcOfBorg eval

@doronbehar
Copy link
Contributor Author

It seems the evaluation has failed because of a3a782e I wonder why I haven't chose it in the first place.

Rebased to master and fixed evaluation.

jonringer
jonringer reviewed Nov 8, 2019
View reviewed changes
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor Author

BTW Thanks for commenting @jonringer !

jonringer
jonringer reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say squash this into 2 commits:

python3Packages.gaia: enable for python3
essentia: init at 2.1_beta5

@doronbehar
Copy link
Contributor Author

Closing. There's a mess with the commits here + there are too much build errors upstream fixed but haven't made a release yet. I'll open a new PR when there's a new release upstream.

@doronbehar doronbehar closed this Feb 16, 2020
@doronbehar doronbehar deleted the package-essentia branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig left review comments

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@doronbehar @nixos-discourse @matthewbauer @aszlig @jonringer