Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cipher: init at 2.0.0 #70386

Merged
merged 1 commit into from Oct 5, 2019
Merged

cipher: init at 2.0.0 #70386

merged 1 commit into from Oct 5, 2019

Conversation

xiorcale
Copy link
Contributor

@xiorcale xiorcale commented Oct 4, 2019

Motivation for this change

Add more curated apps from Elementary OS app store for Pantheon Desktop.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from worldofpeace October 4, 2019 11:32
@ofborg ofborg bot requested a review from worldofpeace October 5, 2019 12:03
worldofpeace
worldofpeace suggested changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this package uses xdg-open in its desktop file

Can you replace xdg-open with a hardcoded path ${xdg_utils}/bin/xdg-open?
You'd need to use substituteInPlace in postPatch.

@xiorcale
Copy link
Contributor Author

xiorcale commented Oct 5, 2019

I updated the PR, but not sure if I did it right, since it's the first time I'm using subsituteInPlace 😅

@ofborg ofborg bot requested a review from worldofpeace October 5, 2019 14:53
@worldofpeace
Copy link
Contributor

Oops, @Kjuvi forgot to request the dropping of ./ on the post_install.py calls as well.
Can you push that?

@xiorcale
Copy link
Contributor Author

xiorcale commented Oct 5, 2019

I was exactly wondering if I should remove it from there too due to your previous comment, I'll do it

worldofpeace
worldofpeace approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified it was patched correctly.

@worldofpeace worldofpeace merged commit fcfc145 into NixOS:master Oct 5, 2019
@worldofpeace
Copy link
Contributor

@Kjuvi Thanks for contributing this ✨

@ofborg ofborg bot requested a review from worldofpeace October 5, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiorcale @worldofpeace