Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dovecot: Fix wrong type in configFile option #70371

Merged
merged 1 commit into from Oct 9, 2019

Conversation

dminuoso
Copy link
Contributor

@dminuoso dminuoso commented Oct 4, 2019

Motivation for this change

The option services.dovecot2.configFile is non-functional because it needs to be of type path since it's fed into environment.etc."dovecot/dovecot.conf".source.

Things done

FIxed services.dovecot2.configFile to require path rather than string.

Tested on our mail deployment.

Notify maintainers

None specified.

@dminuoso dminuoso changed the title Fix wrong type in dovecot module. dovecot: Fix wrong type in configFile option Oct 4, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 9, 2019

Let's try to notify @hrdinka who did the previous refactor of this module

@hrdinka hrdinka merged commit 65be608 into NixOS:master Oct 9, 2019
@hrdinka
Copy link
Contributor

hrdinka commented Oct 9, 2019

Yes you are absolutely right. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants