Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zeronet: Improved config, dynamic user, remove static UI… #70305

Merged
merged 2 commits into from Oct 4, 2019
Merged

nixos/zeronet: Improved config, dynamic user, remove static UI… #70305

merged 2 commits into from Oct 4, 2019

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Oct 3, 2019

Motivation for this change

One less static UID and GID

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Chiiruno Chiiruno force-pushed the dev/zeronet branch 2 times, most recently from 6333aaf to 1bfda39 Compare October 3, 2019 06:27
@Mic92 Mic92 changed the title nixos/zeronet: Improved config, dynamic user, remove static UID and GID nixos/zeronet: Improved config, dynamic user, remove static UI… Oct 4, 2019
@Mic92 Mic92 merged commit bf3360c into NixOS:master Oct 4, 2019
@Chiiruno Chiiruno deleted the dev/zeronet branch October 4, 2019 09:42
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 4, 2019
@Mic92 @dtzWill
nixos/zeronet: Improved config, dynamic user, remove static UI… (NixO…
9ad8590 
…S#70305)

nixos/zeronet: Improved config, dynamic user, remove static UID and GID

(cherry picked from commit bf3360c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Chiiruno @Mic92 @Madouura