Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.spacy_models: add Norwegian and Lithuanian models #70306

Merged
merged 1 commit into from Nov 10, 2019
Merged

python3Packages.spacy_models: add Norwegian and Lithuanian models #70306

merged 1 commit into from Nov 10, 2019

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Oct 3, 2019

Motivation for this change

New models for Lithuanian and Norwegian.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@danieldk danieldk requested a review from FRidh as a code owner October 3, 2019 06:28
@danieldk
Copy link
Contributor Author

danieldk commented Oct 3, 2019

@GrahamcOfBorg build python3Packages.spacy_models.lt_core_news_sm python3Packages.spacy_models.nb_core_news_sm

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/77

@veprbl
Copy link
Member

veprbl commented Nov 7, 2019

cc @danieldk @sdll

@veprbl
Copy link
Member

veprbl commented Nov 7, 2019

@GrahamcOfBorg build python3Packages.spacy_models.lt_core_news_sm python3Packages.spacy_models.nb_core_news_sm

@veprbl veprbl merged commit 5751e00 into NixOS:master Nov 10, 2019
@danieldk danieldk deleted the spacy-new-models branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @nixos-discourse @veprbl