Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emacs lsp-mode: 20190926 -> 20191004 #70409

Closed
wants to merge 3 commits into from
Closed

Emacs lsp-mode: 20190926 -> 20191004 #70409

wants to merge 3 commits into from

Conversation

matthuszagh
Copy link
Contributor

Motivation for this change

This fixes a problem with the master branch of Emacs.

This is the relevant issue addressed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthuszagh
Emacs lsp-mode: 20190926 -> 20191004
72cf13b 
This fixes a problem with the master branch of Emacs.
@adisbladis
Copy link
Member

While I appreciate the PR we usually (ever?) don't bump emacs packages one-by-one.

We have various auto-update scripts for the various emacs package sources in pkgs/applications/editors/emacs-modes, I recommend that you use update-from-overlay that will pull from https://github.com/nix-community/emacs-overlay and shouldn't take more than a minute to run.

@matthuszagh
Copy link
Contributor Author

@adisbladis thanks for the info! I'll do that instead.

@matthuszagh
Copy link
Contributor Author

@adisbladis, I've run the script. In order to avoid force-pushing, I didn't remove the first commit. Let me know if this is an issue and I'll fix it. For my own understanding, when is it ok to submit a PR to update emacs package recipes? Anytime someone wants an upstream change? Or, anytime there's a bug fix in one of the packages? Something else? Thanks.

@matthuszagh
Copy link
Contributor Author

Closing this as it seems another PR has been merged which updates the packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @adisbladis