Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variety: init at 0.7.2-96-g3afe3ab #70380

Merged
merged 2 commits into from Nov 7, 2019
Merged

variety: init at 0.7.2-96-g3afe3ab #70380

merged 2 commits into from Nov 7, 2019

Conversation

zfnmxt
Copy link
Contributor

@zfnmxt zfnmxt commented Oct 4, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zfnmxt
Copy link
Contributor Author

zfnmxt commented Oct 4, 2019 •
edited

Closes #69639

My first package PR: be sure to lob any and all criticism my way

@matthewbauer matthewbauer merged commit 38a012b into NixOS:master Nov 7, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 10, 2019
@matthewbauer @dtzWill
Merge pull request NixOS#70380 from zfnmxt/variety
53b1ca8 
variety: init at 0.7.2-96-g3afe3ab
(cherry picked from commit 38a012b)
@fgaz fgaz mentioned this pull request Nov 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zfnmxt @matthewbauer