-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zeronet/merkle, nixos/zeronet master -> release-19.09 #70383
Conversation
@Chiiruno This looks like a breaking change. Can you tell me if this is required to use Zeronet at all on NixOS 19.09 or is it just yet another (feature?) release that you'd like to see in 19.09? cc @zimbatm IIRC you are using Zeronet. Could you have a look if this is useful? This is the only remaining PR towards 19.09 at the moment and if we do not want / should merge this we should close it. |
Even if it's not required it fixes a RCE: https://github.com/HelloZeroNet/ZeroNet/releases/tag/v0.7.1 |
Otherwise from the changelog it seems that 0.6.x can still work (well except for that cryptic "P2P source code update using ZeroNet protocol"). So we could just backport the fix |
@andir Not required from what I understand, from my tests the transition was smooth. |
Would the old module continue working with the newer package? I have a bit of a bad feeling of breaking configurations during the release. |
I think so, but I haven't tested. |
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
Already in release. |
Motivation for this change
Stable zeronet update for the stable branch.
Tested locally, smooth transition and it seems to work without a hitch.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)