Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeronet/merkle, nixos/zeronet master -> release-19.09 #70383

Closed
wants to merge 4 commits into from

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Oct 4, 2019

Motivation for this change

Stable zeronet update for the stable branch.
Tested locally, smooth transition and it seems to work without a hitch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented Dec 12, 2019

@Chiiruno This looks like a breaking change. Can you tell me if this is required to use Zeronet at all on NixOS 19.09 or is it just yet another (feature?) release that you'd like to see in 19.09?

cc @zimbatm IIRC you are using Zeronet. Could you have a look if this is useful? This is the only remaining PR towards 19.09 at the moment and if we do not want / should merge this we should close it.

@fgaz
Copy link
Member

fgaz commented Dec 12, 2019

Even if it's not required it fixes a RCE: https://github.com/HelloZeroNet/ZeroNet/releases/tag/v0.7.1

@fgaz
Copy link
Member

fgaz commented Dec 12, 2019

Otherwise from the changelog it seems that 0.6.x can still work (well except for that cryptic "P2P source code update using ZeroNet protocol"). So we could just backport the fix

@Chiiruno
Copy link
Contributor Author

@andir Not required from what I understand, from my tests the transition was smooth.
I suppose it's just another release I'd like to see in 19.09, your call.

@andir
Copy link
Member

andir commented Dec 12, 2019

Would the old module continue working with the newer package? I have a bit of a bad feeling of breaking configurations during the release.

@Chiiruno
Copy link
Contributor Author

I think so, but I haven't tested.

@stale
Copy link

stale bot commented Jun 10, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 10, 2020
@Chiiruno
Copy link
Contributor Author

Already in release.

@Chiiruno Chiiruno closed this Nov 18, 2020
@Chiiruno Chiiruno deleted the release-19.09 branch November 18, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants