Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fribidi: 1.0.5 -> 1.0.7 #70310

Merged
merged 1 commit into from Oct 22, 2019
Merged

fribidi: 1.0.5 -> 1.0.7 #70310

merged 1 commit into from Oct 22, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

A certain package I'd like to contribute as well, depends on this version of fribidi.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request Oct 3, 2019
Merged
10 tasks
@teto
Copy link
Member

teto commented Oct 3, 2019

@GrahamcOfBorg build fribidi

@teto
Copy link
Member

teto commented Oct 3, 2019

Note: it might a good idea to base against staging seeing the number of dependencies.

@doronbehar
Copy link
Contributor Author

@teto do you mean, suggesting the change against regular staging?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/61

@FRidh FRidh changed the base branch from master to staging October 22, 2019 08:00
@FRidh FRidh merged commit 7f69e4f into NixOS:staging Oct 22, 2019
@doronbehar
Copy link
Contributor Author

Thanks! Would it be possible that #70312 will be reviewed now that this is merged?

@doronbehar doronbehar deleted the update-fribidi branch March 2, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @teto @nixos-discourse @FRidh