Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: init 4 Plugins #70309

Merged
merged 5 commits into from Oct 3, 2019
Merged

vimPlugins: init 4 Plugins #70309

merged 5 commits into from Oct 3, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Oct 3, 2019

asterisk: init at 2019-09-23
vim-indexed-search: init at 2019-07-04
vim-textobj-variable-segment: init at 2019-05-05
vim-pasta: init at 2018-09-08

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @teto @timokau

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (vimPlugins.YouCompleteMe broken on master due to broken racerd)
diff LGTM
followed vimPlugin commit guidance

[49 built (1 failed), 27 copied (755.8 MiB), 179.5 MiB DL]
error: build of '/nix/store/sny5r74xbp8clf174rxqcrvr3smfw470-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/70309
1 package failed to build:
vimPlugins.YouCompleteMe

24 package were build:
vimPlugins.SpaceCamp vimPlugins.Syntastic vimPlugins.airline vimPlugins.coc-lists vimPlugins.coc-rls vimPlugins.coc-tsserver vimPlugins.fastfold vimPlugins.fugitive vimPlugins.ghcid vimPlugins.rust-vim vimPlugins.vim-abolish vimPlugins.vim-asterisk vimPlugins.vim-autoformat vimPlugins.vim-go vimPlugins.vim-indexed-search vimPlugins.vim-lsc vimPlugins.vim-orgmode vimPlugins.vim-pasta vimPlugins.vim-signify vimPlugins.vim-snippets vimPlugins.vim-textobj-variable-segment vimPlugins.vimtex vimPlugins.yats-vim vimPlugins.zenburn

@jonringer
Copy link
Contributor

@GrahamcOfBorg build vimPlugins.SpaceCamp vimPlugins.Syntastic vimPlugins.airline vimPlugins.coc-lists vimPlugins.coc-rls vimPlugins.coc-tsserver vimPlugins.fastfold vimPlugins.fugitive vimPlugins.ghcid vimPlugins.rust-vim vimPlugins.vim-abolish vimPlugins.vim-asterisk vimPlugins.vim-autoformat vimPlugins.vim-go vimPlugins.vim-indexed-search vimPlugins.vim-lsc vimPlugins.vim-orgmode vimPlugins.vim-pasta vimPlugins.vim-signify vimPlugins.vim-snippets vimPlugins.vim-textobj-variable-segment vimPlugins.vimtex vimPlugins.yats-vim vimPlugins.zenburn

@jonringer jonringer merged commit eef286c into NixOS:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants