Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racerd: 2019-03-20 -> unstable-2019-09-02 #70313

Merged
merged 1 commit into from Oct 3, 2019
Merged

racerd: 2019-03-20 -> unstable-2019-09-02 #70313

merged 1 commit into from Oct 3, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 3, 2019 •
edited

Motivation for this change

while reviewing #70309 I noticed it was broken, most likely from the rustc bump.

Updating the project seems to have fixed the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70313
3 package were build:
rustracerd vimPlugins.YouCompleteMe ycmd

@jonringer jonringer requested a review from marsam October 3, 2019 09:19
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build rustracerd vimPlugins.YouCompleteMe ycmd

@marsam marsam merged commit 3e39e05 into NixOS:master Oct 3, 2019
@marsam
Copy link
Contributor

marsam commented Oct 3, 2019

Thanks!
ported to 19.09 in 8e1ce32

@jonringer jonringer deleted the bump-racerd branch October 3, 2019 15:21
@jonringer
Copy link
Contributor Author

jonringer commented Oct 4, 2019 •
edited

I had to revert the backport, as the bump actually breaks builds for rust<1.38. This will still need to be backported if we decide to bump rustc for 19.09

revert 4a10b03

EDIT:
hydra failure: https://hydra.nixos.org/build/102618306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @marsam