Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtutilities: 6.0.0 -> 6.0.1 #70397

Merged
merged 1 commit into from Oct 9, 2019
Merged

qtutilities: 6.0.0 -> 6.0.1 #70397

merged 1 commit into from Oct 9, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

c0bw3b
c0bw3b approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review seems ok:

Result of nix-review pr 70397 1

1 package failed to build:
  • syncthingtray-minimal
3 package were build:
  • libsForQt5.qtutilities
  • libsForQt511.qtutilities
  • syncthingtray

@doronbehar syncthing-minimal was already failing on Hydra before this.
CMake is still looking for QtWebEngine

-- Building with Qt Widgets GUI.
-- Building WITHOUT Qt Quick GUI.
-- Using Qt WebEngine as web view provider.
-- Using template for webviewdefs.h from QT_UTILITIES installation.
-- Using template for webviewincludes.h from QT_UTILITIES installation.
-- Linking syncthingwidgets against Qt 5 module Qt5::Network.
-- Linking syncthingwidgets against Qt 5 module Qt5::Concurrent.
-- Linking syncthingwidgets against Qt 5 module Qt5::Gui.
-- Linking syncthingwidgets against Qt 5 module Qt5::Widgets.
CMake Error at /nix/store/3ic65d2gpl43sw4din5yvnawcjjslnli-qtutilities-6.0.1/share/qtutilities/cmake/modules/QtLinkage.cmake:63 (find_package):
  By not providing "FindQt5WebEngineWidgets.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "Qt5WebEngineWidgets", but CMake did not find one.

  Could not find a package configuration file provided by
  "Qt5WebEngineWidgets" (requested version 5.6) with any of the following
  names:

    Qt5WebEngineWidgetsConfig.cmake
    qt5webenginewidgets-config.cmake

  Add the installation prefix of "Qt5WebEngineWidgets" to CMAKE_PREFIX_PATH
  or set "Qt5WebEngineWidgets_DIR" to a directory containing one of the above
  files.  If "Qt5WebEngineWidgets" provides a separate development package or
  SDK, be sure it has been installed.

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 9, 2019

@GrahamcOfBorg build libsForQt5.qtutilities

@c0bw3b c0bw3b merged commit 015e3ed into NixOS:master Oct 9, 2019
@doronbehar doronbehar deleted the update-qtutilities branch March 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @c0bw3b