Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openscad: remove useless preBuild phase #70399

Merged
merged 1 commit into from Oct 4, 2019
Merged

openscad: remove useless preBuild phase #70399

merged 1 commit into from Oct 4, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Oct 4, 2019

Motivation for this change

The preBuild phase was introduced to follow a modification in qscintilla
build (76ad279) that forced the library
libqscintilla2_qt5.so to be called libqscintilla2.so. This has been
inproved in 4bf49d9 so the preBuild
trick is not necessary anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@lsix
openscad: remove useless preBuild phase
51c6082 
The preBuild phase was introduced to follow a modification in qscintilla
build (76ad279) that forced the library
libqscintilla2_qt5.so to be called libqscintilla2.so. This has been
inproved in 4bf49d9 so the preBuild
trick is not necessary anymore.
@lsix lsix requested a review from 7c6f434c October 4, 2019 13:31
@ofborg ofborg bot requested review from the-kenny, gebner and bjornfor October 4, 2019 13:52
@gebner gebner merged commit ec181f7 into NixOS:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@the-kenny the-kenny Awaiting requested review from the-kenny

@gebner gebner Awaiting requested review from gebner

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsix @gebner