Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: fix icon not displaying #70353

Merged
merged 1 commit into from
Oct 17, 2019
Merged

neovim: fix icon not displaying #70353

merged 1 commit into from
Oct 17, 2019
+3 −2

Conversation

shreyanshk
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@shreyanshk shreyanshk marked this pull request as ready for review October 3, 2019 22:10
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 3, 2019
teto
teto reviewed Oct 4, 2019
View reviewed changes
pkgs/applications/editors/neovim/wrapper.nix Outdated
@@ -80,6 +80,10 @@ let
substitute ${neovim}/share/applications/nvim.desktop $out/share/applications/nvim.desktop \
--replace 'TryExec=nvim' "TryExec=$out/bin/nvim" \
--replace 'Name=Neovim' 'Name=WrappedNeovim'

# add icon to display
mkdir -p $out/share/pixmaps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regroup this mkdir with the previous one maybe ?

Copy link
Contributor Author

@shreyanshk shreyanshk Oct 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teto ,
Changes added. Please review.

For some reason unbeknownst to me, 15 (!) people were added as reviewers to this PR. I'm terribly sorry the annoyance but I'm not sure how to correct it.

@ofborg ofborg bot added 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust labels Oct 16, 2019
@ofborg ofborg bot added 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 16, 2019
@joachifm joachifm removed their request for review October 16, 2019 20:40
@teto
Copy link
Member

teto commented Oct 17, 2019

tested, I confirm the icon now appears.

@teto teto merged commit 3388941 into NixOS:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto

@alyssais alyssais

@basvandijk basvandijk

@edolstra edolstra

@Ericson2314 Ericson2314

@FRidh FRidh

@infinisil infinisil

@LnL7 LnL7

@matthewbauer matthewbauer

@Mic92 Mic92

@nbp nbp

@peti peti

@ttuegel ttuegel

@WilliButz WilliButz

@zimbatm zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shreyanshk @teto