neovim: fix icon not displaying #70353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teto
reviewed
Oct 4, 2019
| @@ -80,6 +80,10 @@ let | |||
| substitute ${neovim}/share/applications/nvim.desktop $out/share/applications/nvim.desktop \ | |||
| --replace 'TryExec=nvim' "TryExec=$out/bin/nvim" \ | |||
| --replace 'Name=Neovim' 'Name=WrappedNeovim' | |||
|
|
|||
| # add icon to display | |||
| mkdir -p $out/share/pixmaps | |||
There was a problem hiding this comment.
regroup this mkdir with the previous one maybe ?
There was a problem hiding this comment.
@teto ,
Changes added. Please review.
For some reason unbeknownst to me, 15 (!) people were added as reviewers to this PR. I'm terribly sorry the annoyance but I'm not sure how to correct it.
shreyanshk
requested review from
alyssais,
basvandijk,
edolstra,
Ericson2314,
FRidh,
infinisil,
joachifm,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
ttuegel,
WilliButz and
zimbatm
as code owners
ofborg
bot
added
6.topic: erlang
6.topic: GNOME
ofborg
bot
added
6.topic: TeX
|
tested, I confirm the icon now appears. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @