Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hachoir: init at 3.1.1 #70354

Closed
wants to merge 1 commit into from
Closed

Conversation

dadada
Copy link
Contributor

@dadada dadada commented Oct 3, 2019

Motivation for this change

This module provides the hachoir, a Python library to view and edit a binary stream field by field.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vstinner

Sorry, something went wrong.

@dadada dadada requested a review from FRidh as a code owner October 3, 2019 22:10
@dadada dadada force-pushed the timschubert/hachoir branch 3 times, most recently from 9df1b1a to c138b36 Compare October 3, 2019 22:15
@ofborg ofborg bot added 6.topic: python 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2019
@dadada dadada force-pushed the timschubert/hachoir branch from c138b36 to 01ccfea Compare October 4, 2019 10:55
@dadada
Copy link
Contributor Author

dadada commented Oct 4, 2019

Also the tests (both runtests.py and tox) seem to fail, but only when building with nix. During the checkPhase, some files can not be accessed? I'm not sure what the tests do, though.

@dadada dadada force-pushed the timschubert/hachoir branch from 8316b9b to cd493ac Compare October 4, 2019 13:29
@dadada dadada closed this Oct 4, 2019
@dadada dadada force-pushed the timschubert/hachoir branch from cd493ac to f7968df Compare October 4, 2019 13:37
@dadada dadada reopened this Oct 4, 2019
@dadada dadada force-pushed the timschubert/hachoir branch from 21bfa4c to f6808a0 Compare October 4, 2019 13:53
@ofborg ofborg bot added 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 6.topic: python 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 4, 2019
@dadada dadada force-pushed the timschubert/hachoir branch 4 times, most recently from cd476af to 4e62fd0 Compare October 8, 2019 19:10
@dadada dadada force-pushed the timschubert/hachoir branch from 4e62fd0 to 936c038 Compare October 13, 2019 09:11
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@dadada
Copy link
Contributor Author

dadada commented Jun 1, 2020

This is still relevant to me. Marking as WIP, because I vaguely remember that the hachoir package also pulls in the hachoir-wx and hachoir-urwid scripts that don't work without the additional dependencies. I'll restart work soonish.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@dadada dadada changed the title hachoir: init at 3.0a5 WIP: hachoir: init at 3.0a5 Jun 1, 2020
@dadada dadada force-pushed the timschubert/hachoir branch from d9737f8 to da3cff4 Compare June 22, 2020 20:20
@dadada dadada requested a review from jonringer as a code owner June 22, 2020 20:20
@dadada dadada force-pushed the timschubert/hachoir branch from da3cff4 to 3ec3a97 Compare June 23, 2020 11:56
@dadada dadada changed the title WIP: hachoir: init at 3.0a5 hachoir: init at 3.0a5 Jun 23, 2020
@dadada
Copy link
Contributor Author

dadada commented Jun 23, 2020

I don't see a way of excluding some dependencies without breaking parts of the library and some user-facing scripts. You can still override the package options if you want to use hachoir in a headless scenario.

self: super:
{
  hachoir-headless = super.hachoir.override {
    urwidSupport = false;
    wxPythonSupport = false;
    gtkSupport = false;
    qtSupport = false;
  };
}

This will result in parts of the package being broken, though.

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@dadada dadada force-pushed the timschubert/hachoir branch from 3ec3a97 to bd7b1aa Compare January 17, 2021 12:51
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 17, 2021
@dadada dadada changed the title hachoir: init at 3.0a5 hachoir: init at 3.1.1 Jan 17, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
Comment on lines +49 to +50
homepage = "http://hachoir.readthedocs.io/en/latest/install.html";
license = lib.licenses.gpl2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = "http://hachoir.readthedocs.io/en/latest/install.html";
license = lib.licenses.gpl2;
homepage = "http://hachoir.readthedocs.io/en/latest/install.html";
license = lib.licenses.gpl2;

Why the extra whitespace?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 31, 2022
@dadada dadada closed this Apr 1, 2022
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants