Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerdfonts: Use patchShebangs #70356

Merged
merged 1 commit into from
Oct 3, 2019
Merged

nerdfonts: Use patchShebangs #70356

merged 1 commit into from
Oct 3, 2019

Conversation

chkno
Copy link
Member

@chkno chkno commented Oct 3, 2019

In commit e8e191a1be9d after v2.0.0, nerdfonts switched from #!/bin/bash
to #!/usr/bin/env bash. Rather than synchronizing this patching with
that change, just use patchShebangs which handles both cases.

  1. When the next version is released, bumping the version number will Just Work.
  2. In the meantime, this makes it easier to use pre-release versions by bumping the version in an overlay.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
joshka Josh McKinney
In commit e8e191a1be9d after v2.0.0, nerdfonts switched from #!/bin/bash
to #!/usr/bin/env bash.  Rather than synchronizing this patching with
that change, just use patchShebangs which handles both cases.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 3, 2019
@andir andir self-assigned this Oct 3, 2019
@andir andir merged commit f86d3c2 into NixOS:master Oct 3, 2019
@chkno chkno deleted the nerdfonts-shebangs branch October 4, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants