Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "perl-modules: do not create perllocal.pod, for determinism" #70317

Merged
merged 1 commit into from Oct 7, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Oct 3, 2019

This reverts commit d0bad14.

I don’t think we need this any more, because the generated timestamps are
always set to 1970-01-01.

Reverting this will mean we get man pages for perl programs for free,
because those are generally part of the `install' target.

This reverts commit d0bad14.

We don't need this any more, because the generated timestamps are
always set to 1970-01-01.

Reverting this will mean we get man pages for perl programs for free,
because those are generally part of the `install' target.
@alyssais
Copy link
Member Author

alyssais commented Oct 3, 2019

Cc: @alexanderkjeldaas @vcunat

@vcunat
Copy link
Member

vcunat commented Oct 6, 2019

/cc maintainer @edolstra. I know basically nothing about the perl ecosystem, and the author of original commit has been inactive here for years.

@edolstra edolstra merged commit ff8ca92 into NixOS:staging Oct 7, 2019
@hedning
Copy link
Contributor

hedning commented Oct 18, 2019

Seeing a few failures on staging-next (#71221) from this, where adding installTargets = "pure_install"; fixes the build, eg. XMLSAXExpat. Doesn't look like there's that many failures, so probably OK to fix them separately: https://hydra.nixos.org/eval/1549399?filter=perl&compare=1549400&full=#tabs-now-fail

I don't have any insight into the perl stuff either, so not sure if there's a better way to fix the few failures than just adding installTargets. Just came across this when I saw a bunch of gnome3 stuff failing due to XMLSAXExpat.

@alyssais
Copy link
Member Author

alyssais commented Oct 19, 2019 via email

@hedning hedning mentioned this pull request Oct 19, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants