Adding nixops delete-resources command #1201
Merged
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsyanticY
changed the title
nixops/resources/__init__.py
Outdated
| @@ -189,6 +189,16 @@ def destroy(self, wipe=False): | |||
| ) | |||
| return False | |||
|
|
|||
| def clear_state(self): | |||
| """clear this resource state, if possible.""" | |||
| if not self.depl.logger.confirm("are you sure you want to clear resources state {}: this will only remove the resource from the local NixOPS state and the resource may still exist outside of the NixOPS database.".format(self.name)): | |||
There was a problem hiding this comment.
Can you split into multiple lines, something like:
def clear_state(self):
"""clear this resource state, if possible."""
if not self.depl.logger.confirm(
"are you sure you want to clear resources state {}:"
"this will only remove the resource from the local "
"NixOPS state and the resource may still exist outside"
" of the NixOPS database.".format(self.name)):
return False
AmineChikhaoui
requested changes
Oct 22, 2019
scripts/nixops
Outdated
| @@ -81,6 +81,11 @@ subparser.add_argument('--exclude', nargs='+', metavar='MACHINE-NAME', help='des | |||
| subparser.add_argument('--wipe', action='store_true', help='securely wipe data on the machines') | |||
| subparser.add_argument('--all', action='store_true', help='destroy all deployments') | |||
|
|
|||
| subparser = add_subparser(subparsers, 'clear-state', help='clear resources from state file') | |||
There was a problem hiding this comment.
Suggested change
| subparser = add_subparser(subparsers, 'clear-state', help='clear resources from state file') | |
| subparser = add_subparser(subparsers, 'clear-state', help='deletes the resource from the local NixOPS state file.') |
scripts/nixops
Outdated
| @@ -81,6 +81,11 @@ subparser.add_argument('--exclude', nargs='+', metavar='MACHINE-NAME', help='des | |||
| subparser.add_argument('--wipe', action='store_true', help='securely wipe data on the machines') | |||
| subparser.add_argument('--all', action='store_true', help='destroy all deployments') | |||
|
|
|||
| subparser = add_subparser(subparsers, 'clear-state', help='clear resources from state file') | |||
| subparser.set_defaults(op=op_clear_state) | |||
| subparser.add_argument('--include', nargs='+', metavar='MACHINE-NAME', help='clear only the specified machines') | |||
There was a problem hiding this comment.
Suggested change
| subparser.add_argument('--include', nargs='+', metavar='MACHINE-NAME', help='clear only the specified machines') | |
| subparser.add_argument('--include', nargs='+', metavar='RESOURCE-NAME', help='delete only the specified resources') |
scripts/nixops
Outdated
| subparser = add_subparser(subparsers, 'clear-state', help='clear resources from state file') | ||
| subparser.set_defaults(op=op_clear_state) | ||
| subparser.add_argument('--include', nargs='+', metavar='MACHINE-NAME', help='clear only the specified machines') | ||
| subparser.add_argument('--exclude', nargs='+', metavar='MACHINE-NAME', help='clear all resources except the specified machines') |
There was a problem hiding this comment.
Suggested change
| subparser.add_argument('--exclude', nargs='+', metavar='MACHINE-NAME', help='clear all resources except the specified machines') | |
| subparser.add_argument('--exclude', nargs='+', metavar='RESOURCE-NAME', help='delete all except the specified resources') |
PsyanticY
force-pushed
the
clearstate
branch
3 times, most recently
from
6c9b5ec to
49190f2
Compare
PsyanticY
force-pushed
the
clearstate
branch
4 times, most recently
from
868a169 to
63e886f
Compare
This command will allow users to painlessly remove resources from nixops database while preserving the actual resource. This can be helpful in various disater recovery scenarios when we need to attach an EBS volume to prod form shadow or vice versa. then can safely reeuse that deployment since the shadow won't clain the volume transfered to prod as it's own and tires to destory it
AmineChikhaoui
approved these changes
Oct 23, 2019
AmineChikhaoui
changed the title
AmineChikhaoui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command will allow users to painlessly remove resources from nixops database while preserving the actual resource. This can be helpful in various disater recovery scenarios when we need to attach an EBS volume to prod form shadow or vice versa. then can safely reeuse that deployment since the shadow won't clain the volume transfered to prod as it's own and tires to destory it