Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.JSONValidator: init at 3.15 #70335

Merged
merged 1 commit into from Oct 14, 2019
Merged

perlPackages.JSONValidator: init at 3.15 #70335

merged 1 commit into from Oct 14, 2019

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 3, 2019 •
edited

Motivation for this change

JSON::Validator is useful for validating json files against a schema (https://json-schema.org/)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@stigtsp
Copy link
Member Author

stigtsp commented Oct 3, 2019 •
edited

DataValidateDomain, DataValidateIP, NetIDNEncode are added to enable additional format validations.

YAMLLibYAML is added to allow loading JSON schemas in YAML format. https://metacpan.org/source/JHTHORSEN/JSON-Validator-3.15/t/load-yaml.t

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 14, 2019

@GrahamcOfBorg build perl528Packages.JSONValidator perl530Packages.JSONValidator

c0bw3b
c0bw3b approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 70335 1

2 package were build:
  • perl528Packages.JSONValidator
  • perl530Packages.JSONValidator

NetIDNEncode failure on Darwin was here before

@c0bw3b c0bw3b merged commit ff064b4 into NixOS:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @c0bw3b