Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.asyncpg: fix hash of patch #70338

Closed
wants to merge 1 commit into from
Closed

pythonPackages.asyncpg: fix hash of patch #70338

wants to merge 1 commit into from

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Oct 3, 2019

Motivation for this change

This has been broken for as long as this package has existed, on both master and 19.09.

This should probably be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eadwu

@Taneb Taneb requested a review from FRidh as a code owner October 3, 2019 16:22
@eadwu
Copy link
Member

eadwu commented Oct 3, 2019

Worked when initially pushed until the hash changed. Fix is here too #70256.

@ofborg ofborg bot requested a review from eadwu October 3, 2019 16:44
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 3, 2019
@Ma27
Copy link
Member

Ma27 commented Oct 4, 2019

Obsolete as #70256 got merged and will be backported.

@Ma27 Ma27 closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Taneb @eadwu @Ma27 @jonringer