Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql_12: init at 12.0 #70363

Merged
merged 1 commit into from Oct 8, 2019
Merged

postgresql_12: init at 12.0 #70363

merged 1 commit into from Oct 8, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 4, 2019

Motivation for this change

Release notes: https://www.postgresql.org/docs/12/release-12.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from globin, danbst and ocharles October 4, 2019 03:15
@thoughtpolice
Copy link
Member

Ugh, high rebuilds due to the installPhase change. Do we want this to hit staging? A good portion of the changes will be for the extensions (since each extension is effectively built 5x, one for each postgresql major version), so maybe it isn't really that bad...

@globin
Copy link
Member

globin commented Oct 7, 2019

I'd prefer staging, from grepping it seems everything depending on qt will be rebuilt.

@marsam marsam changed the base branch from master to staging October 8, 2019 01:02
@marsam
Copy link
Contributor Author

marsam commented Oct 8, 2019

@globin sure, I've changed the base branch to staging

@globin globin merged commit 6a7f0cc into NixOS:staging Oct 8, 2019
@marsam marsam deleted the init-postgresql-12 branch October 8, 2019 01:15
@danbst danbst mentioned this pull request Oct 11, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

@globin globin Awaiting requested review from globin

@danbst danbst Awaiting requested review from danbst

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @thoughtpolice @globin