Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apacheHttpdPackages.mod_tile: init at unstable-2017-01-08 #70365

Merged
merged 1 commit into from
Nov 6, 2019
Merged

apacheHttpdPackages.mod_tile: init at unstable-2017-01-08 #70365

merged 1 commit into from
Nov 6, 2019
+37 −0

Conversation

jglukasik
Copy link
Contributor

Motivation for this change

Continuing my OSM tools packaging. Changes to the httpd nixos service to "enableTile" like you can "enablePerl" will be coming later, i thought it would be best to do just the nixpkgs for now.

A release for this package hasn't been cut in a long time, so i'm following the naming convention for specifying the latest commit as documented here: https://nixos.org/nixpkgs/manual/#sec-package-naming

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 4, 2019
@aanderse
Copy link
Member

aanderse commented Oct 4, 2019 •
edited
Loading

This is an obscure module compared to mod_perl so I woulda just recommend documenting how to enable it via the extraModules option. Personally I've been trying to cut down on the code in that module and clean it up as it's fairly difficult to understand for those new to the nix language.

@aanderse
Copy link
Member

@GrahamcOfBorg build apacheHttpdPackages.mod_tile
@jglukasik do you have a configuration snippet on how you tested this?

@jglukasik
apacheHttpdPackage.mod_tile: init at unstable-2017-01-08

Verified

This commit was signed with the committer’s verified signature.
tadeokondrak Tadeo Kondrak
GPG key ID: D41E092CA43F1D8B
Verified
Learn about vigilant mode
babd3f7
@jglukasik
Copy link
Contributor Author

Sorry for the delay, and thanks for getting my attention back on this; I realized my maintainers line had an issue (I copied it in a different place that had inherit (stdenv.lib) maintainers at the top of the file). Just updated my commit with that fix ( + meta = with stdenv.lib; { )

As for a config snippet, I've been using the following (real url replaced with XXXX here)

services = {
    httpd = {
       enable = true;
       adminAddr = "fake@XXXX.com";
       hostName = "XXXX.com";
       extraModules = [
         { name = "tile"; path = "${pkgs.apacheHttpdPackages.mod_tile}/modules/mod_tile.so"; }
       ];
    };
};

This should enable a debug page at /mod_tile, which i confirm by running:

jgl@xps ~ $ curl XXXX.com/mod_tile
NoResp200: 0
NoResp304: 0
NoResp404: 0
NoResp503: 0
NoResp5XX: 0
NoRespOther: 0
NoFreshCache: 0
NoOldCache: 0
NoVeryOldCache: 0
NoFreshRender: 0
NoOldRender: 0
NoVeryOldRender: 0
NoRespZoom00: 0
NoTileBufferReads: 0
DurationTileBufferReads: 0
NoTileBufferReadZoom00: 0
DurationTileBufferReadZoom00: 0
jgl@xps ~ $

@aanderse
Copy link
Member

aanderse commented Nov 6, 2019

@GrahamcOfBorg build apacheHttpdPackages.mod_tile

@aanderse aanderse changed the title apacheHttpdPackage.mod_tile: init at unstable-2017-01-08 apacheHttpdPackages.mod_tile: init at unstable-2017-01-08 Nov 6, 2019
aanderse
aanderse approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and runs as described for me. 👍

@aanderse aanderse merged commit 0cad3f6 into NixOS:master Nov 6, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@aanderse @dtzWill
Merge pull request NixOS#70365 from jglukasik/mod_tile

Verified

This commit was signed with the committer’s verified signature.
tadeokondrak Tadeo Kondrak
GPG key ID: D41E092CA43F1D8B
Verified
Learn about vigilant mode
b229e25 
apacheHttpdPackages.mod_tile: init at unstable-2017-01-08

(cherry picked from commit 0cad3f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jglukasik @aanderse