Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qmapshack: 1.13.1 -> 1.13.2 #68609

Merged
merged 1 commit into from
Oct 3, 2019
Merged

qmapshack: 1.13.1 -> 1.13.2 #68609

merged 1 commit into from
Oct 3, 2019
+17 −17

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 12, 2019

Motivation for this change

Changelog:

  • Advanced Filtering System
  • Skip saving of geo search
  • "Clone Waypoint and Move Clone" does not Respect Chosen Units
  • Printing Preview
  • BRouter segments download error
  • Screen overflow German localisation on a Notebook with 1.600 x 900 pixel
  • Tab order in Filter Cycle dialog is confused
  • BRouter setup issue (Windows)
  • Add: Computation of "Energy Use Cycling" (consumption) for cycling tours
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/534cddlvbk5bg12krlxp8nyzg9sajsgq-qmapshack-1.13.1
/nix/store/534cddlvbk5bg12krlxp8nyzg9sajsgq-qmapshack-1.13.1	   1.1G
$ nix path-info -Sh /nix/store/j8z36xkvk937mshfr8nq52i1c60p41qy-qmapshack-1.13.2
/nix/store/j8z36xkvk937mshfr8nq52i1c60p41qy-qmapshack-1.13.2	   1.0G
Notify maintainers

cc @dotlambda

Sorry, something went wrong.

@ofborg ofborg bot requested a review from dotlambda September 12, 2019 19:38
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 12, 2019
@sikmir
Copy link
Member Author

sikmir commented Sep 30, 2019

It looks like @dotlambda is inactive for a long time, @markuskowa could you please review?

@markuskowa
Copy link
Member

markuskowa commented Sep 30, 2019 •
edited
Loading

@GrahamcOfBorg build qmapshack

@markuskowa
Copy link
Member

There seems to be a problem with the download URL:

builder for '/nix/store/wisssp3cl9gr51awq2ppdcjq1g229flb-source.drv' failed with exit code 1; last 7 log lines:
  
  trying https://bitbucket.org/maproom/qmapshack/downloads/qmapshack-1.13.2.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 
  error: cannot download source from any mirror
cannot build derivation '/nix/store/p78qvr9cdc42pf9f7r7yajf5mgyjshjq-qmapshack-1.13.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wp6wspfm4j17shhpanrybd6ysxh2af5g-env.drv': 1 dependencies couldn't be built

@sikmir
Copy link
Member Author

sikmir commented Sep 30, 2019 •
edited
Loading

I see, the project moved to GitHub in the meantime.

@sikmir
Copy link
Member Author

sikmir commented Sep 30, 2019

URL updated.

@markuskowa markuskowa merged commit f7968df into NixOS:master Oct 3, 2019
@sikmir sikmir deleted the qmapshack branch October 3, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa

@dotlambda dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @markuskowa