Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glow: init at 0.1.3 #76213

Merged
merged 1 commit into from Dec 26, 2019
Merged

glow: init at 0.1.3 #76213

merged 1 commit into from Dec 26, 2019

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Dec 23, 2019

Motivation for this change

New package for rendering markdown.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry
Copy link
Contributor Author

ehmry commented Dec 23, 2019

@GrahamcOfBorg build glow

@ofborg ofborg bot requested a review from kalbasit December 23, 2019 05:06
@Br1ght0ne
Copy link
Member

Br1ght0ne commented Dec 26, 2019 •
edited

v0.1.3 is out. https://github.com/charmbracelet/glow/releases/tag/v0.1.3

If @ehmry can update their PR to v0.1.3, I'll close this one.

@Br1ght0ne Br1ght0ne mentioned this pull request Dec 26, 2019
Closed
10 tasks
@ehmry
Copy link
Contributor Author

ehmry commented Dec 26, 2019

@filalex77 I've forced-pushed a v0.1.3 commit, and since its effectively the same as #76530 I added you as a maintainer.

@ehmry ehmry changed the title glow: init at 0.1.2 glow: init at ~0.1.2~ 0.1.3 Dec 26, 2019
@ehmry ehmry changed the title glow: init at ~0.1.2~ 0.1.3 glow: init at 0.1.3 Dec 26, 2019
@ofborg ofborg bot requested a review from Br1ght0ne December 26, 2019 09:35
@ehmry ehmry merged commit 54184df into NixOS:master Dec 26, 2019
@ehmry ehmry deleted the glow branch December 26, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehmry @Br1ght0ne