Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glow: init at 0.1.3 #76530

Closed
wants to merge 1 commit into from
Closed

glow: init at 0.1.3 #76530

wants to merge 1 commit into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 26, 2019 •
edited

Motivation for this change

https://github.com/charmbracelet/glow/releases/tag/v0.1.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Br1ght0ne
Copy link
Member Author

Didn't see #76213 when I was submitting this. If @ehmry can update their PR to v0.1.3, I'll close this one.

@ofborg ofborg bot requested a review from kalbasit December 26, 2019 09:15
@ehmry ehmry mentioned this pull request Dec 26, 2019
Merged
10 tasks
@Br1ght0ne
Copy link
Member Author

Thanks @ehmry!

@Br1ght0ne Br1ght0ne closed this Dec 26, 2019
@Br1ght0ne Br1ght0ne deleted the glow-0.1.3 branch December 26, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Br1ght0ne