New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another batch of Python 2 clean-ups #76488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in 6449435, only Python 2 is supported and it does not seem to be used by anything.
Please restore the libplist bindings. Not building them by default is fine. |
Also remove no longer needed perl.
Nothing much seems to be using it and we do not want Python 2 in our closure.
It does not seem to be used by anything and we want to get rid of Python 2 from closure.
For some reason we depended on both.
It does not appear to be actually necessary – wafHook will add it.
Nothing seems to use the Python bindings anyway.
jtojnar
force-pushed
the
more-python-cleanups
branch
from
December 29, 2019 10:22
8bfffb0
to
4a583c8
Compare
Nodejs is fixed if using _latest instead of _lts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #75668
I was digging through my system’s build-time closure using
nix-store -q --graph $(nix-instantiate -I nixos-config=/etc/nixos/configuration.nix -I nixpkgs=$PWD '<nixpkgs/nixos>' -A system) | dijkstra -da $(nix-instantiate '<nixpkgs>' -A python2) | gvpr -c 'N[dist>1000.0]{delete(NULL, $)}' | xdot -
and eliminating Python 2 from derivations referencing it by replacing it with Python 3 whenever possible.Testing
libplist
gst_all_1.gst-validate
gst_all_1.gst-editing-services
strongswan
libnl
gst_all_1.gst-plugins-ugly
gn
v8
builds with this as wellhtop
mda_lv2
folks
qt5.qtdeclarative
gnumeric
packagekit
libpwquality
crda
(https://lore.kernel.org/linux-wireless/24df021f5e30c51e2d9fff8533ff5591d37d2d2d.camel@gmail.com/)Some packages were not handled in #75668:
asciidoc
(asciidoctor
in Ruby is the new upstream, switch to https://github.com/asciidoc/asciidoc-py3/releases)llvm_*
(not sure about bootstrapping)ninja
(Darwin bootstrapping issue Another batch of Python 2 removals #75668 (comment), https://gist.github.com/GrahamcOfBorg/130aa188dad522a3e0df7ce27006565e)parted
(two tests are failing)spidermonkey_60
(takes too long to build)qtbase
(takes too long to build)telepathy-glib
(telepathy-logger
depends on Python 2)New findings not covered here or in the previous PR:
now patchedcrda
errorlilypond
:ERROR: Please install required programs: python3 < 3.0 (installed: 3.7.5) python3 < 3.0 (installed: 3.7.5) python3 < 3.0 (installed: 3.7.5) Python.h (python-devel, python-dev or libpython-dev package)
dblatex
:zziplib
(handled in zziplib: 0.13.69 → 0.13.71 #85147) docs/makedocs.py is not compatible with python3 gdraheim/zziplib#47:mercurial
(handled in mercurial: 4.9.1 -> 5.2.1 + python3 🚀 #76126)duplicity
(does no support Python 3 in stable version)backblaze-b2
(should be supported but cannot test it)scons
(handled in scons: Switch to Python 3 #75877)subversion
(viacheckInputs
, even when tests are disabled)inkscape
(fixed in upcoming release lib2geom: init at 1.0 #50286)gimp
(fixed in upcoming release gimp: Testing dev version with Meson #67576)mypaint
(fixed in upcoming release mypaint: 1.2.1 → 2.0.0-beta.0 #54677)wafHook
(???)gitAndTools.git-bz
(???)nodejs
(too big, ??? firefox depends on this)firefox
(too big)chromium
(too big)v8
tdesktop
(error: gyp-2015-06-11 not supported for interpreter python3.7
)neard
(GUI tools depend on PyGTK)gitAndTools.git-hub
(:disappointed: Port to Python3 sociomantic-tsunami/git-hub#224)