Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/manual: fixing links for awstats release note #76500

Merged
merged 1 commit into from Dec 25, 2019
Merged

nixos/manual: fixing links for awstats release note #76500

merged 1 commit into from Dec 25, 2019

Conversation

d-goldin
Copy link
Contributor

Motivation for this change

linkend attribute needs to point to an option.
Addresses: #76493

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@d-goldin
nixos/manual: fixing links for awstats release note
64dcbba 
`linkend` attribute needs to point to an option.
@danbst danbst merged commit 2467edf into NixOS:master Dec 25, 2019
@danbst danbst mentioned this pull request Dec 25, 2019
Closed
@d-goldin d-goldin deleted the fix_awstat_release_note branch December 25, 2019 19:22
@aanderse
Copy link
Member

@d-goldin I dropped the ball on this one... thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-goldin @aanderse @danbst