Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

act: init at 0.1.3 #76536

Merged
merged 1 commit into from Dec 28, 2019
Merged

act: init at 0.1.3 #76536

merged 1 commit into from Dec 28, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Dec 26, 2019 •
edited

Motivation for this change

https://github.com/nektos/act/releases/tag/v0.1.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested a review from kalbasit December 26, 2019 15:11
@novoxd
Copy link
Contributor

novoxd commented Dec 27, 2019

LGTM. I previously made derivation for this package #70615, but it was my first nixpkg and I had problems with go build that I could not solve. I think my pr needs to be closed if this merged.

@filalex77 what do you think about adding lines https://github.com/NixOS/nixpkgs/pull/70615/files#diff-5d25eadc3de349ea58152f9721a8296aR16-R18 ? I took them from act Makefile.

@Lassulus can you please review this pr?

@Br1ght0ne
Copy link
Member Author

@novoxudonoser Thanks! Not sure on the subPackages and flags - what are they for? Nonetheless, I'll add you as a collaborator if @Lassulus can let us know whether these lines are beneficial.

jonringer
jonringer approved these changes Dec 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
repo is a little stale, but not seriously so

https://github.com/NixOS/nixpkgs/pull/76536
1 package were built:
act

@jonringer jonringer merged commit af57b17 into NixOS:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novoxd novoxd novoxd approved these changes

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @novoxd @jonringer