Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root: wrap python executables #76541

Merged
merged 1 commit into from Dec 26, 2019
Merged

root: wrap python executables #76541

merged 1 commit into from Dec 26, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 26, 2019

In normal use of ROOT the PYTHONPATH is intended to be set when user
sources the thisroot.{,s}sh. We do that in the setupHook. This covers
the case when thisroot.sh was not sourced.

Motivation for this change

Closes: #76524

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @yipengsun

@veprbl
Copy link
Member Author

veprbl commented Dec 26, 2019

@GrahamcOfBorg build root

@veprbl
root: wrap python executables
0b28198 
In normal use of ROOT the PYTHONPATH is intended to be set when user
sources the thisroot.{,s}sh. We do that in the setupHook. This covers
the case when thisroot.sh was not sourced.
@veprbl
Copy link
Member Author

veprbl commented Dec 26, 2019

@GrahamcOfBorg build root

@veprbl veprbl merged commit 984ceb1 into NixOS:master Dec 26, 2019
@veprbl veprbl deleted the pr/root_python_wrap branch December 26, 2019 19:40
veprbl added a commit that referenced this pull request Dec 26, 2019
@veprbl
root: wrap python executables
c5d5561 
In normal use of ROOT the PYTHONPATH is intended to be set when user
sources the thisroot.{,s}sh. We do that in the setupHook. This covers
the case when thisroot.sh was not sourced.

(cherry picked from commit 0b28198)

cc #76541
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 26, 2019
@veprbl veprbl restored the pr/root_python_wrap branch December 1, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rootbrowse in ROOT package cannot launch properly on macOS
1 participant
@veprbl