Enable OCR for ccextractor #76534

NilsIrl · 2019-12-26T12:27:49Z

Motivation for this change

Although tesseract and leptonica are included as buildInputs, they are unused as OCR is disabled. Enabling it.

Things done

Notify maintainers

NilsIrl · 2019-12-26T12:28:32Z

cmake file: https://github.com/CCExtractor/ccextractor/blob/1e32bee8e5b7d26a431673c31b6107b0e2f9b057/src/CMakeLists.txt#L6

titanous

LGTM, thanks! Whoever does this merge, please run a build of the package on CI first, I don't currently have permissions to trigger it.

NilsIrl · 2019-12-29T21:13:11Z

This could also be added as an option instead of having it for everyone.

stale · 2020-06-27T03:11:27Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

NilsIrl · 2020-06-27T11:35:59Z

@titanous

SuperSandro2000

Please squash all commits together and update the PR title and commit message to ccextractor: enable ocr support

NilsIrl · 2020-12-29T02:58:21Z

Done, however, there's a problem, ccextractor, is unable to locate the tesseract data. CCExtractor/ccextractor#1170 would fix it. But unfortunately it was rejected.

SuperSandro2000 · 2021-01-11T18:17:16Z

pkgs/applications/video/ccextractor/default.nix

@@ -1,5 +1,8 @@
 { stdenv, fetchFromGitHub, pkgconfig, cmake
-, glew, glfw3, leptonica, libiconv, tesseract3, zlib }:
+, glew, glfw3, zlib, libiconv
+, ocrSupport ? true, leptonica ? null, tesseract4 ? null }:


Suggested change

, ocrSupport ? true, leptonica ? null, tesseract4 ? null }:

, ocrSupport ? true, leptonica, tesseract4 }:

pkgs/applications/video/ccextractor/default.nix

SuperSandro2000 · 2021-01-12T00:47:18Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 76534 run on x86_64-linux 1

1 package built:

ccextractor

SuperSandro2000 · 2021-01-12T08:06:59Z

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 76534 run on x86_64-darwin 1

1 package built:

ccextractor

siraben · 2021-01-15T00:16:06Z

pkgs/applications/video/ccextractor/default.nix

@@ -17,7 +20,11 @@ stdenv.mkDerivation rec {

  nativeBuildInputs = [ pkgconfig cmake ];


Suggested change

nativeBuildInputs = [ pkgconfig cmake ];

nativeBuildInputs = [ pkg-config cmake ];

siraben · 2021-01-15T00:16:38Z

pkgs/applications/video/ccextractor/default.nix

@@ -1,5 +1,8 @@
 { stdenv, fetchFromGitHub, pkgconfig, cmake


Suggested change

{ stdenv, fetchFromGitHub, pkgconfig, cmake

{ stdenv, lib, fetchFromGitHub, pkg-config, cmake

siraben · 2021-01-15T00:17:30Z

pkgs/applications/video/ccextractor/default.nix

+, glew, glfw3, zlib, libiconv
+, ocrSupport ? true, leptonica ? null, tesseract4 ? null }:
+
+assert ocrSupport -> leptonica != null && tesseract4 != null;

 with stdenv.lib;


Suggested change

with stdenv.lib;

pkgs/applications/video/ccextractor/default.nix

siraben · 2021-01-15T00:18:32Z

pkgs/applications/video/ccextractor/default.nix

+    "-DWITH_OCR=${if ocrSupport then "ON" else "OFF"}"
+  ];
+
+  buildInputs = [ glew glfw3 leptonica tesseract4 zlib ] ++ stdenv.lib.optional (!stdenv.isLinux) libiconv;

  meta = {


Suggested change

meta = {

meta = with lib; {

siraben · 2021-01-15T00:18:51Z

pkgs/applications/video/ccextractor/default.nix

@@ -29,6 +36,6 @@ stdenv.mkDerivation rec {
    '';
    platforms = platforms.unix;
    license = licenses.gpl2;


gpl2Only or gpl2Plus?

NilsIrl · 2021-01-15T19:05:37Z

Applied suggestions.

I'm ignoring the other suggestions because they belong to another PR

Update to tesseract4 Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

SuperSandro2000 · 2021-01-15T20:29:41Z

pkgs/applications/video/ccextractor/default.nix

@@ -1,5 +1,6 @@
 { lib, stdenv, fetchFromGitHub, pkgconfig, cmake
-, glew, glfw3, leptonica, libiconv, tesseract3, zlib }:
+, glew, glfw3, zlib, libiconv
+, ocrSupport ? true, leptonica ? null, tesseract4 ? null }:

 with lib;


Suggested change

with lib;

Please apply it where it is required.

siraben · 2021-01-16T01:41:53Z

Applied suggestions.

I'm ignoring the other suggestions because they belong to another PR

Please apply the changes in a separate commit ccextractor: refactor. They save having to open another PR for trivial fixes.

stale · 2021-07-21T01:12:09Z

I marked this as stale due to inactivity. → More info

Artturin · 2021-07-28T18:15:32Z

Superseded by #131849

ofborg bot requested a review from titanous December 26, 2019 12:47

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 26, 2019

titanous approved these changes Dec 26, 2019

View reviewed changes

NilsIrl force-pushed the patch-2 branch from 64dbc93 to 0cfe23c Compare December 30, 2019 01:37

ofborg bot requested a review from titanous December 30, 2019 02:57

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 27, 2020

titanous approved these changes Jul 7, 2020

View reviewed changes

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 7, 2020

NilsIrl force-pushed the patch-2 branch from 0cfe23c to 86b102b Compare August 21, 2020 12:10

ofborg bot requested a review from titanous August 21, 2020 19:16

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Aug 21, 2020

SuperSandro2000 requested changes Dec 29, 2020

View reviewed changes

NilsIrl force-pushed the patch-2 branch from 86b102b to ad1e104 Compare December 29, 2020 02:56

SuperSandro2000 requested changes Jan 11, 2021

View reviewed changes

siraben requested changes Jan 15, 2021

View reviewed changes

ofborg bot added the 2.status: merge conflict label Jan 15, 2021

NilsIrl force-pushed the patch-2 branch from 8a357da to 71d371a Compare January 15, 2021 19:16

ccextractor: enable ocr support

65256c6

Update to tesseract4 Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

NilsIrl force-pushed the patch-2 branch from 71d371a to 65256c6 Compare January 15, 2021 19:19

ofborg bot removed the 2.status: merge conflict label Jan 15, 2021

SuperSandro2000 reviewed Jan 15, 2021

View reviewed changes

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021

Artturin mentioned this pull request Jul 28, 2021

ccextractor: enable ocr and hardsub support #131849

Merged

11 tasks

Artturin closed this Jul 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable OCR for ccextractor #76534

Enable OCR for ccextractor #76534

NilsIrl commented Dec 26, 2019

NilsIrl commented Dec 26, 2019

titanous left a comment

NilsIrl commented Dec 29, 2019 •

edited

stale bot commented Jun 27, 2020

NilsIrl commented Jun 27, 2020

SuperSandro2000 left a comment

NilsIrl commented Dec 29, 2020

SuperSandro2000 Jan 11, 2021

SuperSandro2000 commented Jan 12, 2021

SuperSandro2000 commented Jan 12, 2021

siraben Jan 15, 2021

siraben Jan 15, 2021

siraben Jan 15, 2021

siraben Jan 15, 2021

siraben Jan 15, 2021

NilsIrl commented Jan 15, 2021 •

edited

SuperSandro2000 Jan 15, 2021

siraben commented Jan 16, 2021

stale bot commented Jul 21, 2021

Artturin commented Jul 28, 2021

	, ocrSupport ? true, leptonica ? null, tesseract4 ? null }:
	, ocrSupport ? true, leptonica, tesseract4 }:

		@@ -17,7 +20,11 @@ stdenv.mkDerivation rec {

		nativeBuildInputs = [ pkgconfig cmake ];

	nativeBuildInputs = [ pkgconfig cmake ];
	nativeBuildInputs = [ pkg-config cmake ];

	{ stdenv, fetchFromGitHub, pkgconfig, cmake
	{ stdenv, lib, fetchFromGitHub, pkg-config, cmake

Enable OCR for ccextractor #76534

Enable OCR for ccextractor #76534

Conversation

NilsIrl commented Dec 26, 2019

Motivation for this change

Things done

Notify maintainers

NilsIrl commented Dec 26, 2019

titanous left a comment

Choose a reason for hiding this comment

NilsIrl commented Dec 29, 2019 • edited

stale bot commented Jun 27, 2020

NilsIrl commented Jun 27, 2020

SuperSandro2000 left a comment

Choose a reason for hiding this comment

NilsIrl commented Dec 29, 2020

SuperSandro2000 Jan 11, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Jan 12, 2021

SuperSandro2000 commented Jan 12, 2021

siraben Jan 15, 2021

Choose a reason for hiding this comment

siraben Jan 15, 2021

Choose a reason for hiding this comment

siraben Jan 15, 2021

Choose a reason for hiding this comment

siraben Jan 15, 2021

Choose a reason for hiding this comment

siraben Jan 15, 2021

Choose a reason for hiding this comment

NilsIrl commented Jan 15, 2021 • edited

SuperSandro2000 Jan 15, 2021

Choose a reason for hiding this comment

siraben commented Jan 16, 2021

stale bot commented Jul 21, 2021

Artturin commented Jul 28, 2021

NilsIrl commented Dec 29, 2019 •

edited

NilsIrl commented Jan 15, 2021 •

edited