nixos/nginx: fixup permissions for Nginx state dir #76533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit b0bbacb was a bit too fast It did set executable bit for log files. Also, it didn't account for other directories in state dir: ``` # ls -la /var/spool/nginx/ total 32 drwxr-x--- 8 nginx nginx 4096 Dec 26 12:00 . drwxr-xr-x 4 root root 4096 Oct 10 20:24 .. drwx------ 2 root root 4096 Oct 10 20:24 client_body_temp drwx------ 2 root root 4096 Oct 10 20:24 fastcgi_temp drwxr-x--- 2 nginx nginx 4096 Dec 26 12:00 logs drwx------ 2 root root 4096 Oct 10 20:24 proxy_temp drwx------ 2 root root 4096 Oct 10 20:24 scgi_temp drwx------ 2 root root 4096 Oct 10 20:24 uwsgi_temp ``` With proposed change, only ownership is changed for state files, and mode is left as is except that statedir/logs is now group accessible.
|
Thanks, worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit b0bbacb was a bit too fast
It did set executable bit for log files.
Also, it didn't account for other directories in state dir:
With proposed change, only ownership is changed for state files, and mode is left as is
except that statedir/logs is now group accessible.
#76174
cc @flokli @Izorkin @aanderse