Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.graph-tool: 2.27 -> 2.29 #76506

Merged
merged 1 commit into from Jan 4, 2020
Merged

python3.pkgs.graph-tool: 2.27 -> 2.29 #76506

merged 1 commit into from Jan 4, 2020

Conversation

SlothOfAnarchy
Copy link
Contributor

@SlothOfAnarchy SlothOfAnarchy commented Dec 25, 2019 •
edited

The dependency 'pkg-config' was renamed and the two patches have since been
included or resolved.

Motivation for this change

I wanted to use features from a newer version. Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @joelmo @dasJ

@SlothOfAnarchy SlothOfAnarchy changed the title graph-tool: 2.27 -> 2.29 python3.pkgs.graph-tool: 2.27 -> 2.29 Dec 29, 2019
@dasJ
Copy link
Member

dasJ commented Dec 29, 2019

@GrahamcOfBorg eval

python3.pkgs.graph-tool: 2.27 -> 2.29
bf208c8 
The dependency 'pkg-config' was renamed and the two patches have since been
included or resolved.
@ofborg ofborg bot requested a review from joelmo December 30, 2019 00:40
@FRidh
Copy link
Member

FRidh commented Dec 30, 2019

@GrahamcOfBorg build python3.pkgs.graph-tool

@Lassulus Lassulus merged commit d38c463 into NixOS:master Jan 4, 2020
@dasJ dasJ deleted the upd/graph-tool branch January 4, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@joelmo joelmo Awaiting requested review from joelmo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SlothOfAnarchy @dasJ @FRidh @Lassulus @Janik-Haag