Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the boot.vesa option #76481

Merged
merged 1 commit into from Feb 13, 2020
Merged

Deprecate the boot.vesa option #76481

merged 1 commit into from Feb 13, 2020

Conversation

fare
Copy link
Contributor

@fare fare commented Dec 25, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

mmahut commented Feb 13, 2020

Looks good, as this is mostly a documentation change.

@mmahut mmahut merged commit 4011c2a into NixOS:master Feb 13, 2020
Et7f3 added a commit to Et7f3/nixpkgs that referenced this pull request Jun 22, 2022
@Et7f3
headless: Don't use deprecated vesa.
81a8e12 
This option is deprecated as per NixOS#76481
@Et7f3 Et7f3 mentioned this pull request Jun 22, 2022
Merged
mitchmindtree pushed a commit to mitchmindtree/nixpkgs that referenced this pull request Jul 2, 2023
@Et7f3 @mitchmindtree
headless: Don't use deprecated vesa.
f29198c 
This option is deprecated as per NixOS#76481
mitchmindtree pushed a commit to mitchmindtree/nixpkgs that referenced this pull request Jul 2, 2023
@Et7f3 @mitchmindtree
headless: Don't use deprecated vesa.
9cc90da 
This option is deprecated as per NixOS#76481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fare @mmahut @7c6f434c