Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 70564f31b462
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 466921c46ff3
Choose a head ref
  • 5 commits
  • 2 files changed
  • 3 contributors

Commits on Dec 26, 2019

  1. nixosTests.nginx*: port to python

    @globin @Ma27
    globin authored and Ma27 committed Dec 26, 2019
    Copy the full SHA
    1c2781d View commit details
    Browse the repository at this point in the history

  2. nixosTests.nginx*: review fixes 

    Co-Authored-By: Florian Klink <flokli@flokli.de>
    @globin @flokli @Ma27
    2 people authored and Ma27 committed Dec 26, 2019
    Copy the full SHA
    abbce76 View commit details
    Browse the repository at this point in the history

  3. nixos/tests/nginx-sso: add subtests for each assertion

    @Ma27
    Ma27 committed Dec 26, 2019
    Copy the full SHA
    495b0b5 View commit details
    Browse the repository at this point in the history

  4. nixos/nginx: fix test 

    When using format-strings, curly brackets need to be escaped using `{{`
to avoid errors from python.

And apparently, Perl's `==` is used to compare substrings[1] which is why
the translation to `assert http_code == "304"` failed as the string
contains several headers from curl.

[1] Just check `perl <(echo 'die "alarm" if "foo\n304" == 304')`
    @Ma27
    Ma27 committed Dec 26, 2019
    Copy the full SHA
    c5c7ccf View commit details
    Browse the repository at this point in the history

  5. Merge pull request #74072 from mayflower/tests-python-nginx 

    nixosTests.nginx*: port to python
    @Ma27
    Ma27 committed Dec 26, 2019
    Copy the full SHA
    466921c View commit details
    Browse the repository at this point in the history