Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature #2411

Merged
merged 8 commits into from
Dec 25, 2019
Merged

Signature #2411

merged 8 commits into from
Dec 25, 2019

Conversation

eggrobin
Copy link
Member

This pull request introduces Signature; it does introduce usages of it.
We should use it in OrthogonalMap and EulerSolver later on.

Signature is handedness-correct.

template<typename FromFrame, typename ToFrame>
class Signature : public LinearMap<FromFrame, ToFrame> {
public:
static constexpr Sign determinant =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this? Could it be private?

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Dec 25, 2019
@eggrobin eggrobin merged commit 9da8622 into mockingbirdnest:master Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants