Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP jdk: use placeholder for jdk.home #76571

Closed
wants to merge 1 commit into from
Closed

WIP jdk: use placeholder for jdk.home #76571

wants to merge 1 commit into from

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Dec 27, 2019

Previously it used non-fixpointed derivation, which brought old derivation
into closure during overrides.

Fixes https://discourse.nixos.org/t/how-do-you-discover-the-override-attributes-for-a-derivation/5214

However doesn't fix this same problem for oraclejdk and adoptopenjdk-bin,
because those use also self-link for passthru.jre.

I've also omitted this same change for openjdk/bootstrap.nix, because I don't quite understand what is this for, what for is openjdk/make-boostrap.nix and the explanation.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@danbst
jdk: use placeholder for jdk.home
203a8d1 
Previously it used non-fixpointed derivation, which brought old derivation
into closure during overrides.

Fixes https://discourse.nixos.org/t/how-do-you-discover-the-override-attributes-for-a-derivation/5214
However doesn't fix this same problem for `oraclejdk` and `adoptopenjdk-bin`,
because those use also self-link for `passthru.jre`.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-do-you-discover-the-override-attributes-for-a-derivation/5214/15

@danbst danbst changed the title jdk: use placeholder for jdk.home WIP jdk: use placeholder for jdk.home Dec 27, 2019
@danbst
Copy link
Contributor Author

danbst commented Dec 27, 2019

Okay, this is somehow wrong. placeholder doesn't do what I expect.

@danbst
Copy link
Contributor Author

danbst commented Dec 27, 2019

I'll better close this as all this jdk.home/jdk.jre doesn't sound right, and I don't want to spend too much time here.

@danbst danbst closed this Dec 27, 2019
@danbst danbst deleted the fix-jetbrains-jdk-src-ref branch December 27, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlolli hlolli Awaiting requested review from hlolli

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danbst @nixos-discourse