Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyslurm: change maintainer #76549

Merged
merged 2 commits into from Dec 28, 2019
Merged

pythonPackages.pyslurm: change maintainer #76549

merged 2 commits into from Dec 28, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 26, 2019

Motivation for this change

I can't maintain this package anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @markuskowa @jagajaga

@bhipple
Copy link
Contributor

bhipple commented Dec 27, 2019

I'd be willing to help maintain this. From what I remember, the only major issue with it is just that it used to be really picky about slurm versions, but we've resolved that now, right?

PySlurm/pyslurm@d3703f2

@veprbl veprbl changed the title pythonPackages.pyslurm: remove pythonPackages.pyslurm: change maintainer Dec 27, 2019
@veprbl veprbl requested a review from bhipple December 27, 2019 22:44
@veprbl veprbl merged commit 596fa28 into NixOS:master Dec 28, 2019
@veprbl veprbl deleted the pr/pyslurm_remove branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@markuskowa markuskowa markuskowa approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @bhipple @markuskowa