Make docker-containers restart policy configurable #76479
Conversation
A user might not want a container to always be restarted and this option allows them to freely choose between the restart policies that upstream systemd provides as of version 243. The previous default behavior of "always" is preserved.
| @@ -161,6 +161,15 @@ let | |||
| ["--network=host"] | |||
| ''; | |||
| }; | |||
| restart = mkOption { | |||
| type = types.enum [ "no" "on-success" "on-failure" "on-abnormal" "on-watchdog" "on-abort" "always" ]; | |||
There was a problem hiding this comment.
Does docker run implement the systemd watchdog pinger?
There was a problem hiding this comment.
I don't think it does currently but a user might patch their docker with this and I don't see much reason to leave it out either.
|
There is a new approach in #77479. I don't quite know now which approach will be used eventually. |
|
That approach is quite a drastic change as it makes the container run as a daemon managed by dockerd instead of a service managed by systemd. My approach is more conservative as it only enhances the current functionality without changing the default behavior at all. |
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
Motivation for this change
A user might not want a container to always be restarted and this option allows them to freely choose between the restart policies that upstream systemd provides as of version 243.
The previous default behavior of "always" is preserved.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @