Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agda-stdlib: list as not broken on Darwin #76485

Merged
merged 1 commit into from Dec 25, 2019
Merged

agda-stdlib: list as not broken on Darwin #76485

merged 1 commit into from Dec 25, 2019

Conversation

ryanorendorff
Copy link
Contributor

Motivation for this change

The Agda standard library builds on Darwin (Catalina). Remove the broken flag in the meta data of agda-stdlib to reflect this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) (no tests available)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip". Passed
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (didn't find any about this issue).
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jwiegley @laMudri

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Dec 25, 2019
@danbst danbst merged commit 2d2146b into NixOS:master Dec 25, 2019
@danbst
Copy link
Contributor

danbst commented Dec 25, 2019

I don't have Mac but I'll trust you.

@ryanorendorff ryanorendorff deleted the agda-not-broken-darwin branch December 25, 2019 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanorendorff @danbst @Janik-Haag