Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains: 2019.2.x -> 2019.3.x #76504

Closed
wants to merge 1 commit into from
Closed

jetbrains: 2019.2.x -> 2019.3.x #76504

wants to merge 1 commit into from

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Dec 25, 2019 •
edited

Motivation for this change

Update to latest available JetBrains IDEs (2019.3.x).

Things done

Generated new versions with standard script.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@kuznero kuznero requested a review from edwtjo as a code owner December 25, 2019 16:11
@kolaente
Copy link
Member

kolaente commented Dec 28, 2019 •
edited

There is #73879 which does the same as this one, maybe we should close one.

@kuznero
Copy link
Member Author

kuznero commented Dec 28, 2019

Indeed, closing.

@kuznero kuznero closed this Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuznero @kolaente