darktable: fix missing lensfun files #76529
Conversation
When darktable starts we get an error that looks like this: [iop_lens]: could not load lensfun database in `/nix/store/...-darktable-3.0.0/share/lensfun/version_2'!
| preFixup = let | ||
| libPathEnvVar = if stdenv.isDarwin then "DYLD_LIBRARY_PATH" else "LD_LIBRARY_PATH"; | ||
| libPathPrefix = "$out/lib/darktable" + stdenv.lib.optionalString stdenv.isLinux ":${ocl-icd}/lib"; | ||
| in '' | ||
| gappsWrapperArgs+=( | ||
| --prefix ${libPathEnvVar} ":" "${libPathPrefix}" | ||
| ) | ||
| ln -s ${lensfun}/share/lensfun $out/share |
There was a problem hiding this comment.
Instead of having lensefun a dependency is it possible to point darktable to the directory via an environment variable? We could then just have a wrapper around darktable setting that instead of triggering a rebuild of darktable when lensefun changes.
There was a problem hiding this comment.
It would be nice to avoid rebuilds, but:
- It does not seem like there is an env variable to use (based on this)
lensfunis already one of thebuildInputsofdarktable(so it already triggers a rebuild)
There was a problem hiding this comment.
Would not it be preferable to patch the path here: https://github.com/darktable-org/darktable/blob/d9d279a1e1b38baaab07981dfa6bc87fe16238cf/src/iop/lens.cc#L1259
Or open an issue to respect XDG_DATA_DIRS?
There was a problem hiding this comment.
Oh. Interesting. I had not looked in there. I am on macOS so it might be that the only problem is that the lensfun Load function is not actually being tried first if __APPLE__ is defined https://github.com/darktable-org/darktable/blob/d9d279a1e1b38baaab07981dfa6bc87fe16238cf/src/iop/lens.cc#L1246-L1249
There was a problem hiding this comment.
Indeed, on Linux, the correct system path should be hopefully tried: https://github.com/lensfun/lensfun/blob/b58ac41f0f62000acdf6e73e0b5ef7c9af72efef/libs/lensfun/database.cpp#L93-L117
Maybe patching it to use Load on macOS too would be enough.
There was a problem hiding this comment.
I don't see this issue on Linux. I'm not sure if darktable's cmake detects the platform as macOS and tries to build everything into one bundle, as masOS expects it, but this fix sholdn't be necessary on linux.
|
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
stale
bot
added
the
2.status: stale
|
Also note that the version of lensfun shipped in 20.03 doesn't work correctly. In my own setup, I've reverted to 0.3.2 |
stale
bot
removed
the
2.status: stale
|
Is this still an issue on master/20.09? I can use lensfun here just fine (NixOS Unstable), but #76529 (comment) seems to suggest it's a Darwin-only problem. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to lack of feedback. If this is still an issue on MacOS, please reopen. |
Motivation for this change
When darktable starts we get an error that looks like this:
Lens correction fails to work correctly (no thing is found).
Things done
A symlink to the
lensfundatabase is added inpreFixup.It looks like there might be an error in
lensfunor the darktablecode that uses it. With the missing database fixed the following
error is reported on startup:
And when the program exits it gives:
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @